Skip to content

usb: dwc2: masquerade split-interrupt transfers #6936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2025

Conversation

P33M
Copy link
Contributor

@P33M P33M commented Jul 4, 2025

Second attempt at porting the dwc_otg hack to avoid dropped split transactions.

Transactions now "look OK" on the bus analyser but this needs more soak testing with different hub implementations.

@P33M P33M marked this pull request as ready for review July 8, 2025 09:21
P33M added 2 commits July 8, 2025 13:16
Masquerading Interrupt split transfers as Control puts the transfer into
the non-periodic handler in the hub. This stops the hub dropping
complete-split data in the microframe after a CSPLIT should have
arrived, improving resilience to host IRQ latency. Devices are none
the wiser - the handshake tokens are the same.

Originally devised by Hans Petter Selasky @ FreeBSD.

(v2: dwc2 needs an un-masquerade prior to channel interrupt handling)

Signed-off-by: Jonathan Bell <[email protected]>
Control Setup phase transfers needs an 8 byte maxpacket override, or
drivers doing a GET with a small buffer as a split transaction would
cause broken transfers.

Signed-off-by: Jonathan Bell <[email protected]>
@P33M P33M force-pushed the dwc2_masquerade branch from 9d4c59b to fbd7bc9 Compare July 8, 2025 12:16
@pelwell
Copy link
Contributor

pelwell commented Jul 8, 2025

GitHub notifications about status changes and pushes are hit and miss.

@pelwell pelwell merged commit 3829e1b into raspberrypi:rpi-6.12.y Jul 8, 2025
12 checks passed
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Jul 11, 2025
kernel: Add support for phy interrupts on BCM54213PE
See: raspberrypi/linux#6942

kernel: usb: dwc2: masquerade split-interrupt transfers
See: raspberrypi/linux#6936
popcornmix added a commit to raspberrypi/rpi-firmware that referenced this pull request Jul 11, 2025
kernel: Add support for phy interrupts on BCM54213PE
See: raspberrypi/linux#6942

kernel: usb: dwc2: masquerade split-interrupt transfers
See: raspberrypi/linux#6936
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants